Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add family 15h ......................................................................
Patch Set 5:
(11 comments)
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 31: >
Spelling or the use of a box comment style (>)?
Marshall suggests I should remove it completely
https://review.coreboot.org/c/coreboot/+/34561/4/Documentation/soc/amd/famil... PS4, Line 38: may be viewed as analogous to the : Intel® Management Engine
I wanted to call attention to the fact that it's a separate processor within the SOC just like Intel […]
Ok, will remove.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 6: attend a broad spectrum
You "attend" a party but not a spectrum of users. […]
Removed
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 5: Family 15h is available in several models with different numbers of cores : and some other small variations,
No, there's no relation between Family 15h vs. Family 14h. […]
Ack
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 7: micro architecture
Thanks, will fix.
Removed
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 9: use separate
Thanks, will fix.
Done
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 12: , which all [Family 17h](family17h.md) : will also use.
Since this is an "AMD Family 15h document, I think they should all be addressed. […]
Done
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 19: PSP
Reading back, I agree. Will remove.
Done
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 29: coreboo
Oops....
Done
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 43: Control
Thanks.
Done
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 45: References
I'm only asking for links to documents.
Done