EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40501 )
Change subject: deltaur: Split up chromeos.fmd
......................................................................
Patch Set 1:
LGTM, but this will add little complexity of ME re-packing and coreboot-private files. GBE region is no harm if we add it but not use it. Like Arcada doesn't have onboard LAN but we still add GBE for it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40501
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib93d5ba7f8dbf273ba7c1163022661ede1f44ab4
Gerrit-Change-Number: 40501
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 18 Apr 2020 05:24:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment