[coreboot-gerrit] Change in coreboot[master]: cpu/x86: Make MP init timeout configurable

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )

Change subject: cpu/x86: Make MP init timeout configurable
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38546/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38546/9//COMMIT_MSG@15 
PS9, Line 15: needs to be heuristic
> During the MP init (flight plan) process, the MSRs of each cpu (thread) need to be set up. […]

It can also be desirable to return an error code sooner and handle the failure quickly, assuming it's possible to handle such an error by turning off APs or whatever. Particularly for systems with fewer cores/threads since they're likely to be in embedded/mobile systems where people still care about boot time and can't easily replace parts.

I don't think that failed APs is really an undefined state, but if it were then we should just forget about timeouts and loop indefinitely.