Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31561 )
Change subject: payloads/tianocore: Add option for custom bootsplash ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31561/1/payloads/external/tianocore/Makefile File payloads/external/tianocore/Makefile:
https://review.coreboot.org/#/c/31561/1/payloads/external/tianocore/Makefile... PS1, Line 92: if [[ "$(CONFIG_TIANOCORE_BOOTSPLASH_FILE)" = /* ]]; then \
[[ is non-standard, iirc
recommended substitution?
https://review.coreboot.org/#/c/31561/1/payloads/external/tianocore/Makefile... PS1, Line 95: $$(dirname "$$(dirname "$$(dirname "$(CURDIR)")")")
Isn't $(top) available here?
will check, was looking for something like that but couldn't find it at the time :)
https://review.coreboot.org/#/c/31561/1/payloads/external/tianocore/Makefile... PS1, Line 109: git checkout CorebootPayloadPkg/Logo/Logo.bmp > /dev/null 2>&1
It’s unlikely, but if changes were staged already, then this wouldn’t do anything. […]
I'd assume if there are staged changes, then the user doesn't want them overwritten. This is just to clear the bootslpash copied as part of the build process, which will definitely not be staged