Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47411 )
Change subject: soc/intel/common: Adapt XHCI elog driver for reuse ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47411/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47411/5//COMMIT_MSG@18 PS5, Line 18:
Is there a bug for this? TEST?
is the gsmi handler in the kernel fixed yet? the version I have on my volteer is still broken.
https://review.coreboot.org/c/coreboot/+/47411/2/src/soc/intel/common/block/... File src/soc/intel/common/block/north_xhci/elog.c:
PS2:
Isn't this exactly the same as common/block/xhci/elog. […]
Done
https://review.coreboot.org/c/coreboot/+/47411/5/src/soc/intel/common/block/... File src/soc/intel/common/block/xhci/elog.c:
https://review.coreboot.org/c/coreboot/+/47411/5/src/soc/intel/common/block/... PS5, Line 111: elog_add_event_wake(wake_info[i].elog_wake_type_host, 0);
Oops yes, missed the check, but yeah forgot the s0ix resume clearing the wake status bit. […]
Done