[coreboot-gerrit] Change in coreboot[master]: drivers/generic/ioapic: Drop enable_virtual_wire

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Stefan Ott, Furquan Shaikh, Alexander Couzens, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55287 )

Change subject: drivers/generic/ioapic: Drop enable_virtual_wire
......................................................................

Patch Set 5:

(1 comment)

File src/arch/x86/ioapic.c:

https://review.coreboot.org/c/coreboot/+/55287/comment/0e89872b_294052a7 
PS5, Line 82: 	write_vector(ioapic_base, 0, high, low);
Looking at 7series / C216 doc 326776-003

PIC / i8259 has connected i8254 counter 0 as IRQ0. table 5-13
IOAPIC has i8254 counter 0 connected to "pin 2" or "vector IRQ2". table 5-16

IMO this should have modified redirection table entry #2, not #0 within the IOAPIC. That would have correllated with:

/* INT_SRC_OVR */
    current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)
    	 current, 0, 0, 2, 0);