Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31173 )
Change subject: google/mistral: Support triggering Recovery/FDR. ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/31173/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31173/1//COMMIT_MSG@7 PS1, Line 7: google/mistral: Support triggering Recovery/FDR. Please remove the dot/period at the end of the commit message summary.
https://review.coreboot.org/#/c/31173/1//COMMIT_MSG@10 PS1, Line 10: switch(GPIO77) Please add a space before the (.
https://review.coreboot.org/#/c/31173/1//COMMIT_MSG@11 PS1, Line 11: Please elaborate why vboot wipeout needs to be selected.
Tested how?
https://review.coreboot.org/#/c/31173/1/src/mainboard/google/mistral/board.h File src/mainboard/google/mistral/board.h:
https://review.coreboot.org/#/c/31173/1/src/mainboard/google/mistral/board.h... PS1, Line 4: * Copyright (C) 2018, The Linux Foundation. All rights reserved. Is that the correct line?
https://review.coreboot.org/#/c/31173/1/src/mainboard/google/mistral/chromeo... File src/mainboard/google/mistral/chromeos.c:
https://review.coreboot.org/#/c/31173/1/src/mainboard/google/mistral/chromeo... PS1, Line 87: //display_pattern(WWR_NORMAL_BOOT); What is the comment good for?