mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31449 )
Change subject: src/device/Kconfig: Add support for discrete VGA OpROM inclusion at config UI ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31449/1/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/#/c/31449/1/src/device/Kconfig@618 PS1, Line 618: depends on ARCH_X86 && MULTIPLE_VGA_ADAPTERS
I disagree: MULTIPLE_VGA_ADAPTERS option already surrounds important AMD-specific code at AMD northb […]
Update: it turned out that the already-existing-at-coreboot-master MULTIPLE_VGA_ADAPTERS code is not required for getting a dGPU working, although it has not been ruled out that this code could not be somehow useful (e.g. for getting the Crossfire working) or essential for some other board, because for this G505S almost all this already-existing code never runs at the moment, blocked by another check. More information at - https://review.coreboot.org/c/coreboot/+/31448#message-86a7c4f33a958847d16f9...
In any case this MULTIPLE_VGA_ADAPTERS name is perfectly suitable for what I am doing, but if you disagree, please suggest a better name