View Change
1 comment:
File src/device/Kconfig:
Patch Set #1, Line 618: depends on ARCH_X86 && MULTIPLE_VGA_ADAPTERS
I disagree: MULTIPLE_VGA_ADAPTERS option already surrounds important AMD-specific code at AMD northb […]
Update: it turned out that the already-existing-at-coreboot-master MULTIPLE_VGA_ADAPTERS code is not required for getting a dGPU working, although it has not been ruled out that this code could not be somehow useful (e.g. for getting the Crossfire working) or essential for some other board, because for this G505S almost all this already-existing code never runs at the moment, blocked by another check. More information at - https://review.coreboot.org/c/coreboot/+/31448#message-86a7c4f33a958847d16f9ae5a239b20b37054023
In any case this MULTIPLE_VGA_ADAPTERS name is perfectly suitable for what I am doing, but if you disagree, please suggest a better name
To view, visit change 31449. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a7bf0fe95c833cf3df0c7cb20fc27b6ab218c5a
Gerrit-Change-Number: 31449
Gerrit-PatchSet: 2
Gerrit-Owner: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org>
Comment-In-Reply-To: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-MessageType: comment