Eugene Myers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37392 )
Change subject: cpu/x86/smm/smm_stub: Add x86_64 support
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37392/7/src/cpu/x86/smm/smm_stub.S
File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/37392/7/src/cpu/x86/smm/smm_stub.S@...
PS7, Line 190: #include <cpu/x86/64bit/entry64.inc>
Maybe some idea's for moving the page tables into SMM (for follow up patches): […]
Copying the PGTBL won't work as the pointers to the next level will be incorrect.
There exists a 4G page table generator in SmmStc.c (stm_gen_4g_pagetable_x64(uint32_t pagetable_base)) that could be used (or modified to suit).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37392
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26300492e4be62ddd5d80525022c758a019d63a1
Gerrit-Change-Number: 37392
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eugene Myers
cedarhouse1@comcast.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sun, 16 Aug 2020 00:30:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment