Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30822 )
Change subject: sb/intel/i82801gx: Detect if the southbridge supports AHCI
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/30822/11/src/southbridge/intel/i82801gx/sata...
File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/#/c/30822/11/src/southbridge/intel/i82801gx/sata...
PS11, Line 64: return;
The print message needs updating, but if the first function on the PCI device cannot be found it mak […]
Yeah, technically we could die() here. Though, even with that information
in mind, wouldn't it be nicer if one can read (and follow) the code without
having to think about it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d9f4e63ae8b2862c422938f3103c44e761bcda4
Gerrit-Change-Number: 30822
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 06 Jun 2019 09:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment