Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32541 )
Change subject: soc/mediatek: Register coreboot table for ATF
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32541/4/src/soc/mediatek/common/bl3...
File src/soc/mediatek/common/bl31_plat_params.c:
https://review.coreboot.org/c/coreboot/+/32541/4/src/soc/mediatek/common/bl3...
PS4, Line 33: if (!cbtable_param.value) {
This is following rk3399 implementation. […]
To make this easier to read, it's also possible to introduce one flag:
static int cbtable_injected = 0;
if (ctable_injected)
return plat_params;
cbtable_param.value = (uint64_t)cbmem_find(CBMEM_ID_CBTABLE);
if (cbtable_param.value) {
register_bl31_param(&cbtable_param.h);
cbtable_injected = 1;
}
return plat_params;
Do you prefer this version?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32541
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e39495988159608c1c4bbf16a97c86e526bd82b
Gerrit-Change-Number: 32541
Gerrit-PatchSet: 4
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Ho
Ben.Ho@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: You-Cheng Syu
youcheng@google.com
Gerrit-Comment-Date: Fri, 05 Jul 2019 09:08:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment