Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35967 )
Change subject: mb/google/poppy/variant/nocturne: don't invert GPP_D17 ......................................................................
Patch Set 1:
Patch Set 1:
Check sensor are still working with tast test: "tast -build=false -verbose run <ip> hardware.SensorRing"
Gwendal, tast fails in the following way :
(cr) (firmware-nocturne-10984.B/(a41058a...)) nvaccaro@nvaccaro ~/trunk/src/scripts $ tast -verbose run $KOHAKU hardware.SensorRing 2019/10/15 15:01:21 Command line: tast -verbose run 100.90.30.10 hardware.SensorRing 2019/10/15 15:01:21 Using SSH key /home/nvaccaro/trunk/chromite/ssh_keys/testing_rsa 2019/10/15 15:01:21 Using SSH dir /home/nvaccaro/.ssh 2019/10/15 15:01:21 Writing results to /tmp/tast/results/20191015-150121 2019/10/15 15:01:21 Connecting to 100.90.30.10 2019/10/15 15:01:22 Getting architecture from target 2019/10/15 15:01:22 Building chromiumos/tast/local/bundles/cros from /home/nvaccaro/trunk/src/platform/tast-tests 2019/10/15 15:01:26 Built test bundle in 4.592s 2019/10/15 15:01:26 Pushing test bundle /tmp/tast/build/x86_64/local_bundles/cros to /usr/local/libexec/tast/bundles/local_pushed on target 2019/10/15 15:01:27 Pushed test bundle in 690ms (sent 3.1 MB) 2019/10/15 15:01:27 Getting data file list from target 2019/10/15 15:01:27 Failed building or pushing tests: failed to get data file list: Process exited with status 2: args not set for mode 2