Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41232 )
Change subject: drivers/ocp/ipmi: Implement set POST start/end command
......................................................................
Patch Set 1:
Patch Set 1:
Shouldn't "post start" be send in bootblock and "post end" before payload hand-off?
"post start" should wait for the finish of ipmi init, so I add this in ramstage.
About "post end", do you mean to use call back of boot state to implement?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41232
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I597924740e770a7880fd545ffda32c3ab9767ea1
Gerrit-Change-Number: 41232
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 21 May 2020 06:14:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment