Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51748 )
Change subject: soc/amd/common: Add func to clear eSPI IO & memory decode ranges
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/51748/comment/ca16ad84_72ed3a91
PS2, Line 108: for (idx = 0; idx < ESPI_GENERIC_IO_WIN_COUNT; idx++) {
: espi_write16(ESPI_IO_RANGE_BASE(idx), 0);
: espi_write8(ESPI_IO_RANGE_SIZE(idx), 0);
: }
: for (idx = 0; idx < ESPI_GENERIC_MMIO_WIN_COUNT; idx++) {
: espi_write32(ESPI_MMIO_RANGE_BASE(idx), 0);
: espi_write16(ESPI_MMIO_RANGE_SIZE(idx), 0);
: }
I think `espi_write32(ESPI_DECODE, 0);` right before configure_decodes should be sufficient. […]
Agree with that. espi_write32(ESPI_DECODE, 0); should be sufficient here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51748
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4e67c40d34915505bdd5b431a064d2c7b6bbc70
Gerrit-Change-Number: 51748
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 24 Mar 2021 02:48:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment