Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32047 )
Change subject: soc/apl: Add several audio options to devicetree
......................................................................
Patch Set 4:
Patch Set 4:
Again, why is it useful to set those?
Is there a general rule to have all FSP options be configurable in coreboot?
In general I think it should be possible that most (not all) of the FSP options are configureable by the mainboard. Because they are existing and why not?
Also, some of them are configured for my mainboard through slimbootloader.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32047
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1522ae81cba5fc08605f4eb349b2977facd3f669
Gerrit-Change-Number: 32047
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 25 Mar 2019 12:27:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment