Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36418 )
Change subject: [NOT FOR MERGE]: Demo adding near_reset_vector symbol
......................................................................
Patch Set 1:
(1 comment)
Build test with aopen/dxplplusu shows regression.
https://review.coreboot.org/c/coreboot/+/36418/1/src/cpu/x86/16bit/entry16.i...
File src/cpu/x86/16bit/entry16.inc:
https://review.coreboot.org/c/coreboot/+/36418/1/src/cpu/x86/16bit/entry16.i...
PS1, Line 44: .type _start16bit, @function
With SIPI_VECTOR_IN_ROM _start16bit alignment has to be enforced. IPI message using ap_sipi_vector_in_rom discards bottom 12 bits of address (see entry16.ld). Yes, it is only old P4 that really needs it, but there is still some activity with such ancient platform.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36418
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e7888c778e1d1cc426e4160543f4a4662ebf834
Gerrit-Change-Number: 36418
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 29 Oct 2019 07:14:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment