Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )
Change subject: nb/intel/i945: Program CxODT value for each channel ......................................................................
Patch Set 31:
(3 comments)
https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945... PS31, Line 2442: printk(BIOS_DEBUG, "one dimm per channel config..\n"); But it could also be, that there is no DIMM in that channel, right? What would be wrong with
sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED || sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED
that means, at least one DIMM slot(?) is populated?
https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945... PS31, Line 2433: int cas, i; Use `unsigned int`.
https://review.coreboot.org/c/coreboot/+/18548/31/src/northbridge/intel/i945... PS31, Line 2434: u8 dimm_mask = 0; What does the `dimm_mask` do? Add a comment?