Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38044 )
Change subject: amd_blobs: Always set default paths ......................................................................
Patch Set 1:
Maybe I don't quite understand the intent behind this. Are you saying you want to force a build error when !USE_AMD_BLOBS && !(user setting CONFIG_ path strings)? Right now the Makefile.inc interprets empty strings as absence of the blobs and builds/runs OK with warning messages. My initial impression is that I would prefer it stay as-is.
Right, that's exactly the two sides of the coin. And I expected some discussion here :)
For other targets, we decided to have build errors instead of warnings if a build is likely to brick when flashed (only likely, because one can add files to CBFS afterwards, but who does that?).
I have no strong feelings about it, just wanted to bring it up. If somebody prefers to add the files post-make, I'm ok with the current defaults. But if not, I see no reason not to force an error.
AFAICS, the abuild problem should be solved without this change.
Yep.