[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Change in SaGv options

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30917 )

Change subject: soc/intel/cannonlake: Change in SaGv options
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/#/c/30917/10/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/30917/10/src/soc/intel/cannonlake/chip.h@112 
PS10, Line 112: #if IS_ENABLED(CONFIG_SOC_INTEL_CANNONLAKE)
> This check is not correct. SOC_INTEL_CANNONLAKE is selected for all: CNL, CFL, WHL. […]

Definitely. Would it make sense to add a Kconfig option to distinguish between CNL/CFL/WHL common and CNL-specific stuff?