Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46402 )
Change subject: soc/mediatek/mt8192: devapc: add basic dapc drivers ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... File src/soc/mediatek/mt8192/devapc.c:
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 6: unsigned long uintptr_t
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 6: unsigned long uintptr_t
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 12: &val you're setting at address zero? Or do you want to get?
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 14: void*)MAS_SEC maybe put this as variable
void *mas_sec = (void *)MAS_SEC;
https://review.coreboot.org/c/coreboot/+/46402/4/src/soc/mediatek/mt8192/dev... PS4, Line 28: master_sec_init what about rename this to your comment - init_master_sideband() ?