Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44570 )
Change subject: soc/mediatek/mt8192: Do dram full calibration ......................................................................
Patch Set 19:
(7 comments)
https://review.coreboot.org/c/coreboot/+/44570/18/src/soc/mediatek/mt8192/me... File src/soc/mediatek/mt8192/memory.c:
https://review.coreboot.org/c/coreboot/+/44570/18/src/soc/mediatek/mt8192/me... PS18, Line 145: printk(BIOS_ERR, "DRAM-K: Failed to run fast calibration in %ld msecs, error:%d\n",
Line too long (>96 chars)
Ack
https://review.coreboot.org/c/coreboot/+/44570/18/src/soc/mediatek/mt8192/me... PS18, Line 145: :
One space after ":"
Ack
https://review.coreboot.org/c/coreboot/+/44570/18/src/soc/mediatek/mt8192/me... PS18, Line 146: stopwatch_duration_msecs
Align this with BIOS_ERR
Ack
https://review.coreboot.org/c/coreboot/+/44570/18/src/soc/mediatek/mt8192/me... PS18, Line 153: stopwatch_duration_msecs(&sw));
Same
Ack
https://review.coreboot.org/c/coreboot/+/44570/18/src/soc/mediatek/mt8192/me... PS18, Line 161: Starting
Running
Ack
https://review.coreboot.org/c/coreboot/+/44570/18/src/soc/mediatek/mt8192/me... PS18, Line 168: stopwatch_duration_msecs(&sw));
Same
Ack
https://review.coreboot.org/c/coreboot/+/44570/18/src/soc/mediatek/mt8192/me... PS18, Line 177: stopwatch_duration_msecs(&sw));
Same
Ack