build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47388 )
Change subject: soc/intel/elkhartlake: Adding PSE TSN support & PSE UPDs configs ......................................................................
Patch Set 1:
(48 comments)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/K... File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/K... PS1, Line 236: string "TSN MAC adress binary path and filename" 'adress' may be misspelled - perhaps 'address'?
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/K... PS1, Line 239: The path and filename of the TSN mac adress binary. 'adress' may be misspelled - perhaps 'address'?
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 63: if (CONFIG(PSE_IMAGE)) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 63: if (CONFIG(PSE_IMAGE)) suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 93: params->PchPseTgpio7PinMux= 0x8B82A40B; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 94: params->PchPseTgpio8PinMux= 0x8B80A607; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 95: params->PchPseTgpio9PinMux= 0x8B80A808; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 96: params->PchPseTgpio10PinMux= 0x8B86AA07; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 97: params->PchPseTgpio11PinMux= 0x8B86AC0B; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 98: params->PchPseTgpio12PinMux= 0x8B86AE13; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 99: params->PchPseTgpio13PinMux= 0x8B85B00C; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 100: params->PchPseTgpio14PinMux= 0x8B90B214; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 101: params->PchPseTgpio15PinMux= 0x8B90B403; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 102: params->PchPseTgpio16PinMux= 0x8B90B607; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 103: params->PchPseTgpio17PinMux= 0x8B90B80F; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 104: params->PchPseTgpio18PinMux= 0x8B90BA06; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 105: params->PchPseTgpio19PinMux= 0x8B8DBC01; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 108: params->PchPsePwmPinMux[8]= 0x7B706604; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 109: params->PchPsePwmPinMux[9]= 0x7B706805; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 110: params->PchPsePwmPinMux[10]= 0x7B706A06; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 111: params->PchPsePwmPinMux[11]= 0x7B706C11; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 112: params->PchPsePwmPinMux[12]= 0x7B706E12; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 113: params->PchPsePwmPinMux[13]= 0x7B707013; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 114: params->PchPsePwmPinMux[14]= 0x4B64720A; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 115: params->PchPsePwmPinMux[15]= 0x4B64740B; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 116: params->PchPseSpiMosiPinMux[1]= 0x4B852003; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 117: params->PchPseSpiMisoPinMux[1]= 0x4B853002; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 118: params->PchPseSpiClkPinMux[1]= 0x4B854001; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 119: params->PchPseSpiCs0PinMux[1]= 0x4B855000; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 120: params->PchPseI2sTxPinMux[0]= 0x1B702610; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 121: params->PchPseI2sRxPinMux[0]= 0x1B70160F; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 122: params->PchPseI2sSfrmPinMux[0]= 0x1B704614; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 123: params->PchPseI2sSclkPinMux[0]= 0x1B703615; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 126: params->EnableAllThermalFunctions =0x1; spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 127: params->PchPseEcliteEnabled =0x0; spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 129: if (CONFIG(ENABLE_TSN)){ suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 129: if (CONFIG(ENABLE_TSN)){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 130: params->PchPseGbeEnable[0]=config->PSE_TSN[0]; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 131: params->PchPseGbeEnable[1]=config->PSE_TSN[1]; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 132: trailing whitespace
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 134: params->TsnMacAddrBase = (uint32_t)cbfs_boot_map_with_leak(\ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 138: trailing whitespace
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 139: params->TsnConfigBase = (uint32_t)cbfs_boot_map_with_leak(\ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 144: params->PseTsnIpConfigBase = (uint32_t)cbfs_boot_map_with_leak(\ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 149: params->PseTsnGbeSgmiiEnable[0]=0x1; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 150: params->PseTsnGbeSgmiiEnable[1]=0x1; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 151: params->PseTsnGbePhyInterfaceType[0]=0x1; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/1/src/soc/intel/elkhartlake/f... PS1, Line 152: params->PseTsnGbePhyInterfaceType[1]=0x1; spaces required around that '=' (ctx:VxV)