Jingle Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35367 )
Change subject: mb/ocp/monolake: Add a GPIO table for initializing custom configurations ......................................................................
Patch Set 3:
(2 comments)
Patch Set 2:
(14 comments)
I went thru the GPIO listing and have a few questions, particular concerning the MGPIOs, SATA pins, and OC pins.
Some GPIOs listed don't seem to exist. It should be safe to set them as inputs as you have done, I just wanted to note them in case we're looking at different schematics/datasheets.
Your gpio findings are correct with our schematics. We configure these gpios by following the proprietary UEFI BIOS configurations, after comparing the ITP gpio dump they are the same after applying this change.
https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/gpio.h:
https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/... PS1, Line 21: static const struct gpio_config gpio_tables[] = {
Header files are generally only used for declarations. […]
Done
https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/... PS1, Line 50: 28
in follow up patch, could you please provide string literals for these numbers that are actually use […]
Done