Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46511 )
Change subject: security/vboot: Add new TPM NVRAM index MRC_RW_HASH_NV_INDEX ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46511/13/src/drivers/mrc_cache/mrc_... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46511/13/src/drivers/mrc_cache/mrc_... PS13, Line 183: vboot_recovery_mode_enabled() ? : MRC_REC_HASH_NV_INDEX : MRC_RW_HASH_NV_INDEX
This should still be kept as MRC_REC_HASH_NV_INDEX. […]
Done
https://review.coreboot.org/c/coreboot/+/46511/13/src/security/vboot/antirol... File src/security/vboot/antirollback.h:
https://review.coreboot.org/c/coreboot/+/46511/13/src/security/vboot/antirol... PS13, Line 63: recovery
s/recovery/MRC?
Done
https://review.coreboot.org/c/coreboot/+/46511/13/src/security/vboot/antirol... PS13, Line 73: recovery
s/recovery/MRC hash?
Done
https://review.coreboot.org/c/coreboot/+/46511/13/src/security/vboot/antirol... PS13, Line 84: recovery
s/recovery/MRC?
Done
https://review.coreboot.org/c/coreboot/+/46511/13/src/security/vboot/secdata... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/46511/13/src/security/vboot/secdata... PS13, Line 324: * our hands.
Can you also remove all this TPM1 stuff concerning the MRC hash, now that we have forbidden that any […]
Ok, I think that it was CL-8 in the list that Furquan described here: https://review.coreboot.org/c/coreboot/+/46432/1/src/security/vboot/mrc_cach...