Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36657 )
Change subject: lib/fmap: Add optional pre-RAM cache
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36657/9/src/lib/fmap.c
File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/36657/9/src/lib/fmap.c@119
PS9, Line 119: if (!region_device_sz(&cache->rdev))
Suppose car_get_var_ptr returns 0 (e.g. when hitting just the wrong time in CAR migration), this looks for != 0 at address 4-8 (depending on pointer size)? There seem to be issues with FSP 1.0 related to this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2820436776ef620bdc4481b5cd4b6957764248ea
Gerrit-Change-Number: 36657
Gerrit-PatchSet: 9
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 18 Nov 2019 14:31:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment