build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46060 )
Change subject: rules.h: change verstage name if it starts before bootblock
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46060/2/util/cbmem/cbmem.c
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/46060/2/util/cbmem/cbmem.c@785
PS2, Line 785: const char *regex[] = { BANNER_REGEX("verstage-before-bootblock"),
char * array declaration might be better as static const
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46060
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica38f6bfeb05605caadac208e790fd072b352732
Gerrit-Change-Number: 46060
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 07 Oct 2020 03:33:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment