Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Kangheui Won.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53905 )
Change subject: psp_verstage: remove not-implemented files for cezanne
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/psp_verstage/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/53905/comment/eb412e84_458b28f4
PS1, Line 17: ifneq ($(CONFIG_SOC_AMD_CEZANNE),y)
i don't like having checks for certain SoCs in the common code, since this will probably cause some issues when adding new SoCs. if the code is specific to picasso, i'd either move it back to the picasso folder or if it isn't picasso-specific have some kconfig options to select the different interface revisions like i did for example in soc/amc/common/block/psp
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibaab4e8435624d403ef18e980146ebfd1598b61b
Gerrit-Change-Number: 53905
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Comment-Date: Fri, 07 May 2021 14:53:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment