Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43908 )
Change subject: mb/intel/kblrvp: Factor out `HeciEnabled` ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43908/4/src/mainboard/intel/kblrvp/... File src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43908/4/src/mainboard/intel/kblrvp/... PS4, Line 132: empty line
https://review.coreboot.org/c/coreboot/+/43908/4/src/mainboard/intel/kblrvp/... PS4, Line 133: does not match devicetree! HECI is will function disable hence PCI enumeration is required bt setting below HeciEnabled config will ensure device is not visible to PCI tree after booting to OS. But that doesn't mean, HECI is not functional. this is to fix OS HECI driver issue after booting to OS.