Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37990 )
Change subject: soc/intel: Add get_pmbase ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/apollolake/pm... File src/soc/intel/apollolake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/apollolake/pm... PS3, Line 251: No blank line.
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/quark/acpi.c File src/soc/intel/quark/acpi.c:
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/quark/acpi.c@... PS3, Line 113: & B_QNC_LPC_PM1BLK_MASK; Do both lines fit into 96 character line?