Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36654 )
Change subject: libpayload: keyboard: Ignore special keys ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36654/13/payloads/libpayload/driver... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/36654/13/payloads/libpayload/driver... PS13, Line 249: if (media_key_mapping_callback != NULL) { : if (ch == MEDIA_KEY_PREFIX) {
nit: this could be a single statement
Done
https://review.coreboot.org/c/coreboot/+/36654/13/payloads/libpayload/driver... PS13, Line 252: ret = media_key_mapping_callback(ch); : return ret;
nit: return media_key_mapping_callback(ch);
Done
https://review.coreboot.org/c/coreboot/+/36654/14/payloads/libpayload/driver... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/36654/14/payloads/libpayload/driver... PS14, Line 251: return (media_key_mapping_callback(ch));
return is not a function, parentheses are not required
Done