Attention is currently required from: Martin Roth, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51325 )
Change subject: soc/intel/fast_spi/Makefile: Rewrite 16mib check for legibility
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I have pushed CB:51359 to fix the above behavior. […]
fmaptool already writes this header file, I guess. We could make it
also write the same information in make variables. Just like kconfig
provides files to include in C and make.
(marking as resolved, I see nothing to do for this change)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51325
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7bfba0d7864fc091ee6003e09b705fd7254e99b
Gerrit-Change-Number: 51325
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 12 Mar 2021 13:43:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment