Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36812 )
Change subject: AGESA,binaryPI: Move SCI enable outside table creation
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36812/2/src/southbridge/amd/pi/huds...
File src/southbridge/amd/pi/hudson/lpc.c:
https://review.coreboot.org/c/coreboot/+/36812/2/src/southbridge/amd/pi/huds...
PS2, Line 377: .init = lpc_final,
Same here
.final = lpc_final, ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36812
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37810771090dd9b0377f9a72c7a17ef1564ccf68
Gerrit-Change-Number: 36812
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Nov 2019 11:31:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment