Attention is currently required from: David Wu, Tim Wawrzynczak, Paul Menzel, Zhuohao Lee. Alan Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59086 )
Change subject: drivers/net/r8168: Add support for Realtek RT8125 ......................................................................
Patch Set 12:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59086/comment/9c2465b2_5f816dc4 PS7, Line 9: The Realtek RT8168 and RT8125 have a similar programming : interface, therefore add the PCI device ID for the RT8125 : into driver for support.
Please reflow for 75 characters per line.
Fixed.
https://review.coreboot.org/c/coreboot/+/59086/comment/2ba2f498_aa420bea PS7, Line 14: TEST=emerge-brask coreboot chromeos-bootimage
Oh, google/brask. Still the second questions remains.
Added the testing detail in the message.
Patchset:
PS5:
separate commit?
Yes. We are now working on LED part in commit https://review.coreboot.org/c/coreboot/+/59531.
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/59086/comment/b25b24bd_76860ba2 PS4, Line 255: /* : * Refer to RTL8111H datasheet 7.2 Customizable LED Configuration : * Starting from offset 0x18 : * Bit[15:12] LED Feature Control(FC) : * Bit[11:08] LED Select for PINLED2 : * Bit[07:04] LED Select for PINLED1 : * Bit[03:00] LED Select for PINLED0 : * : * Speed Link10M Link100M Link1000M ACT/Full : * LED0 Bit0 Bit1 Bit2 Bit3 : * LED1 Bit4 Bit5 Bit6 Bit7 : * LED2 Bit8 Bit9 Bit10 Bit11 : * FC Bit12 Bit13 Bit14 Bit15 : */ : : /* Set customized LED registers */ : outw(config->customized_leds, io_base + CMD_LED0_LED1);
This is incorrect for the 8125. […]
Yes. We are now working on this in commit https://review.coreboot.org/c/coreboot/+/59531.
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/59086/comment/812a8ed5_490730b4 PS7, Line 1287: #define PCI_DEVICE_ID_REALTEK_8125 0x8125
Please sort them.
Sorted.