[coreboot-gerrit] Change in coreboot[master]: soc/intel/jasperlake: Add VR Configuration settings

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45645 )

Change subject: soc/intel/jasperlake: Add VR Configuration settings
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45645/5/src/soc/intel/jasperlake/ch... 
File src/soc/intel/jasperlake/chip.h:

https://review.coreboot.org/c/coreboot/+/45645/5/src/soc/intel/jasperlake/ch... 
PS5, Line 140: uint32_t 
as per this  https://review.coreboot.org/c/coreboot/+/45825/3/src/mainboard/google/dedede...  : here range is 0-200, can you check appropriate data type uint8_t ?

https://review.coreboot.org/c/coreboot/+/45645/5/src/soc/intel/jasperlake/ch... 
PS5, Line 141: uint32_t 
https://review.coreboot.org/c/coreboot/+/45825/3/src/mainboard/google/dedede...  :  here range is 0-63999, can you check for this also appropriate data type uinit16_t might be enough ?