Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7 ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... File src/mainboard/gigabyte/ga-z170x-gaming7/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... PS2, Line 190: [4] = 0, \ : [5] = 0, \
Done
Done
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... PS2, Line 193: # SATA4 and SATA5 are located in the lower right corner : # of the board, but there is no connector for this
Done
Done
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... PS2, Line 330: chip superio/nuvoton/nct6791d
Not at all!
Done
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... File src/mainboard/gigabyte/ga-z170x-gaming7/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... PS2, Line 34: // CPU
Please drop, it does not provide any value.
Just the comment or the include aswell?
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... File src/mainboard/gigabyte/ga-z170x-gaming7/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... PS2, Line 26: ports : constant Port_List :=
The rest of Ada code is indented with three spaces
Done
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... File src/mainboard/gigabyte/ga-z170x-gaming7/gpio.h:
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... PS2, Line 25: static const struct pad_config gpio_table[] = {
Are these correct?
The values have been retrieved from the board.