Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32161 )
Change subject: mb/google/hatch: Add Kohaku board ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32161/2/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
PS2: Just noting so that we have captured this some where. Multiple things need to change here:
1. BOARD_ROMSIZE_KB needs to be different for different variants 2. FMD file needs to be different for different variants. 3. MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE might not apply to all variants. 4. DIMM_SPD_SIZE will be different for different variants.