Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31325 )
Change subject: lenovo/g505s/Kconfig: Set framebuffer graphics mode to VESA 118h mode
......................................................................
Patch Set 4:
It's not me but HJK who discovered this effect, and he did it with coreboot 4.8 at November 2018. Here is his full message from the archives: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/LRKJP... .
Ok, it seems he didn't mention the exact config and
I'm rather sure that SET_VESA_MODE alone doesn't
make a difference. So I guess we can close this.
Sorry, I really should have said it at the beginning and also add "Signed-off-by: Hans Jürgen Kitter eforname@freemail.hu" to this patch as well.
You cannot sign off for other people.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31325
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b4eacf61d905f1160531a988e192c3b626dca68
Gerrit-Change-Number: 31325
Gerrit-PatchSet: 4
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Mar 2019 20:44:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment