Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41900 )
Change subject: soc/amd/common/blocks/xhci: Add an AMD block to generate xHCI ACPI nodes
......................................................................
Patch Set 2:
(1 comment)
I like this idea, it looks like a lot of it could go in common code in drivers/usb even.
https://review.coreboot.org/c/coreboot/+/41900/2/src/soc/amd/common/block/xh...
File src/soc/amd/common/block/xhci/xhci.c:
https://review.coreboot.org/c/coreboot/+/41900/2/src/soc/amd/common/block/xh...
PS2, Line 102: };
maybe also handle acpi_name in here too
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ebaef342e45923bc181ceebef882358d33f0d1
Gerrit-Change-Number: 41900
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jun 2020 23:10:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment