Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/25336
Change subject: mb/google/poppy: Mask the leftmost 16 bits of board_sku_id ......................................................................
mb/google/poppy: Mask the leftmost 16 bits of board_sku_id
We use uint32_t(4 bytes) to read sku id from EC, but get the wrong value of higher 16 bits.
BUG=b:74177699 BRANCH=poppy TEST=Verify SKU ID value by mosys or ectool cbi command.
Change-Id: Id831b7c30ad9f02328292700622bfc485a374fdc Signed-off-by: amanda_hwang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/25336/1
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 4fc3d88..2d5079d 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -33,7 +33,7 @@ return sku_id; if (google_chromeec_cbi_get_sku_id(&id)) return SKU_UNKNOWN; - sku_id = id; + sku_id = id & 0xFFFF;
return sku_id; }