Chris Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29830 )
Change subject: mb/google/sarien/variants/sarien: Enable melf touchscreen
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29830/2/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/#/c/29830/2/src/mainboard/google/sarien/variants...
PS2, Line 124: GPP_B13
There does not seem to be a dedicated touchscreen reset pin, this is PLTRST and doesn't seem like wh […]
According schematic, the reset_gpio is connected with PLTRST.
Please see issue 119799550 #5(https://partnerissuetracker.corp.google.com/issues/119799550#comment5).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I926c988c141628ae2d98206f9eb615d06357a366
Gerrit-Change-Number: 29830
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Crystal Lin
crystal_lin@compal.corp-partner.google.com
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 30 Nov 2018 10:43:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment
