Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46683 )
Change subject: nb/intel/haswell/early_init.c: Remove invalid register writes
......................................................................
Patch Set 4: Code-Review-1
I would like to talk about this before it goes in... For instance,
it's possible that the bit in SSKPD gives the MRC a hint what to
do. Also, reserved often just means "reserved from your eyes".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21d9656a7595d47ac8648c08d223b7cbafd213c3
Gerrit-Change-Number: 46683
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 24 Oct 2020 10:16:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment