Attention is currently required from: Furquan Shaikh, Martin Roth, Jonathan Zhang, Paul Menzel, Angel Pons, Arthur Heymans. Mariusz Szafrański has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51180 )
Change subject: util/sconfig: Fix for multidomain support sconfig/devicetree.cb ......................................................................
Patch Set 5:
(1 comment)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/51180/comment/bbb9fc9a_5f7845a7 PS5, Line 1344: extern DEVTREE_CONST struct device *const __pci_%d_%02x_%d
Does this make sense? You'd sort of expect this to be a PCI's BDF but that's not the case with the m […]
We need something that will distinguish devices on different domains - so why not use domain number here (meybe move before "pci" in name? or use another flag to mark it is domain and not bus) We only have root buses here and parent is domain. So it is more like "DDF"("D"omain, root bus "D"evice and "F"unction) than full pci BDF in variable name to prevent name conflict. It is early "static" stage when we don`t have final pci root bus numbers that could be used instead of domain numbers. ptr->parent->dev->path_a == 0 means first domain - so using this we will prevent adding devices from other domain defined in devicetree so reverting what this patch was for.