Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46984 )
Change subject: mb/purism/librem_cnl: Add new variant 'Librem Mini v2' ......................................................................
Patch Set 7:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46984/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46984/2//COMMIT_MSG@10 PS2, Line 10: Cometlake
Nit: Comet Lake
Ack
https://review.coreboot.org/c/coreboot/+/46984/2/Documentation/mainboard/pur... File Documentation/mainboard/purism/librem_mini_v2.md:
https://review.coreboot.org/c/coreboot/+/46984/2/Documentation/mainboard/pur... PS2, Line 9: Cometlake
Nit: Comet Lake […]
Done
https://review.coreboot.org/c/coreboot/+/46984/2/Documentation/mainboard/pur... PS2, Line 58: `sudo ./cbmem -1 | grep 'ME:'`
Do you want this on the same line in the result oder “as a box”? […]
Done
https://review.coreboot.org/c/coreboot/+/46984/2/Documentation/mainboard/pur... PS2, Line 67:
nit: trailing space
Done
https://review.coreboot.org/c/coreboot/+/46984/2/Documentation/mainboard/pur... PS2, Line 67: an
*c*an
Done
https://review.coreboot.org/c/coreboot/+/46984/2/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini_v2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46984/2/src/mainboard/purism/librem... PS2, Line 22: SaGv_Enabled
SaGv_FixedHigh for better bootup times
not relevant with newer patch set