Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35167 )
Change subject: soc/skylake/vr_config: Add VR config for Skylake S ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35167/2/src/soc/intel/skylake/vr_co... File src/soc/intel/skylake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/35167/2/src/soc/intel/skylake/vr_co... PS2, Line 176: else if (tdp >= 45) : icc_max[VR_IA_CORE] = VR_CFG_AMP(70);
if I'm not mistaken, then this isn't in the documentation. The Iccmax_GT for 45 watts is missed. […]
SKL-H values appear on a different document: #332986
I made a table for Skylake:
Segment IA GT (GT/GTx) SA -------------------------------------------- S (95W) quad 100 45 11.1 S (80W) quad 82 45 11.1 S (65W) quad 79 45 11.1 S (45W) quad 70 0 11.1 S (35W) quad 66 35 11.1 S (25W) quad 55 35 11.1
S (54W) dual 58 48 11.1 S (51W) dual 45 48 11.1 S (35W) dual 40 48 11.1
H (65W) GT4 74 105/24 8 H (45W) GT4 74 94/20 8 H (45W) GT2 68 55 11.1 H (35W) GT4 66 94/20 8 H (35W) GT2 60 55 11.1
U (28W) GT3 32 57/19 5.1 U (15W) GT3 29 57/19 5.1 U (15W) GT2 29 31 4.5
Y (6W) 24 24 4.1 Y (4.5W) 24 24 4.1