Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34332 )
Change subject: mediatek/mt8183: Support DDR frequency 3600Mbps
......................................................................
Patch Set 12:
Hi Huayang, this looks like a huge patch with multiple fixed merged together.
Can you split this into smaller chunks, and each fixing one topic at a time?
I think it may include:
- Add mode register init function
- Replace hard-coded init sequence by complete logic
- Add DDR frequency 3600Mbps for eMCP DDR
- Fix DDR frequency at 3600Mbps
(although I'm not sure why you said you have to add first then fix)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34332
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1378ca43fb333c445ca77e7dc0844cdf65f2207
Gerrit-Change-Number: 34332
Gerrit-PatchSet: 12
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Sj Huang
sj.huang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Aug 2019 14:36:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment