Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38539 )
Change subject: ec/google/chromeec: Add new host command, EC_CMD_GET_PD_PORT_CAPS
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38539/2/src/ec/google/chromeec/ec_c...
File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/38539/2/src/ec/google/chromeec/ec_c...
PS2, Line 5900:
Tabs?
This file is actually copied over from EC code base: https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master... and so it would be good to maintain consistency with that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38539
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I923e4b637a2f41ce173d378ba5030f1ae8c22222
Gerrit-Change-Number: 38539
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Jan 2020 04:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment