[coreboot-gerrit] Change in coreboot[master]: soc/mediatek: Pass dram info to cbmem

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Xi Chen, Paul Menzel, Julius Werner, Xixi Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61334 )

Change subject: soc/mediatek: Pass dram info to cbmem
......................................................................

Patch Set 22:

(3 comments)

File src/soc/mediatek/common/memory.c:

https://review.coreboot.org/c/coreboot/+/61334/comment/f166bbc6_4c8dd487 
PS21, Line 110: MEM_CHIP_LPDDR4X
> Yes, all LP4X.

Ack

File src/soc/mediatek/common/memory.c:

https://review.coreboot.org/c/coreboot/+/61334/comment/e5577180_b59171b1 
PS22, Line 123: 	p = (void *)((uintptr_t)mc + sizeof(*mc));
> If you want to do something like this, please use […]

It is written this way intentionally, to avoid the "subscript above array bounds" error (due to -Werror=array-bounds). We've seen a similar error in vboot (CL:3133544). However, I don't know why we don't have problems in https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src....

https://review.coreboot.org/c/coreboot/+/61334/comment/3fff7b8a_fca00e94 
PS22, Line 131: 		++p;
> Please don't run two variables through the same loop unless really necessary. […]

Like I said above, unfortunately we cannot write it this way. I'd suggest using `p[i]` here.