Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44493 )
Change subject: commonlib/storage/mmc: Add DS and DDR50 speed modes
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44493/2/src/commonlib/storage/mmc.c
File src/commonlib/storage/mmc.c:
https://review.coreboot.org/c/coreboot/+/44493/2/src/commonlib/storage/mmc.c...
PS2, Line 197: Increase
Yes, initially "SDHCI bus clock: 0. […]
Ah, it increases from reset default speed. Is this reset speed what `mmc_select_ds` would program?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44493
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic75a3815a47e99e054d2cea2e82757740caffd1a
Gerrit-Change-Number: 44493
Gerrit-PatchSet: 4
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Oct 2020 16:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment