Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46585 )
Change subject: soc/mediatek/mt8192: add dram log prefix ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/Kco... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/Kco... PS2, Line 36: low, : medium and high
Yes, 8192 contains 7 freqs. […]
Ack
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/mem... File src/soc/mediatek/mt8192/memory.c:
https://review.coreboot.org/c/coreboot/+/46585/2/src/soc/mediatek/mt8192/mem... PS2, Line 23: result != 0
Actually, the return type of complex_mem_test() is int (not enum cb_err), and I only see one instanc […]
Ack
https://review.coreboot.org/c/coreboot/+/46585/6/src/soc/mediatek/mt8192/mem... File src/soc/mediatek/mt8192/memory.c:
https://review.coreboot.org/c/coreboot/+/46585/6/src/soc/mediatek/mt8192/mem... PS6, Line 24: e Also add {} for the else block for consistency. See the last paragraph of https://doc.coreboot.org/coding_style.html#placing-braces-and-spaces.